[tx] Fix older standalone train script to fix CI#926
Merged
pcmoritz merged 1 commit intoNovaSky-AI:mainfrom Jan 23, 2026
Merged
[tx] Fix older standalone train script to fix CI#926pcmoritz merged 1 commit intoNovaSky-AI:mainfrom
pcmoritz merged 1 commit intoNovaSky-AI:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes the standalone training script by updating how logits are computed in the loss_fn. The change replaces direct access to output.logits with a call to model.compute_logits(output.last_hidden_state). This aligns with recent model API changes where the model's __call__ method returns a CausalLMOutput object that no longer contains a logits attribute. The fix is correct and necessary for the training script to function properly and resolve the CI failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #919 to fix the CI